Merge branch 'fixErrors-893' into 'main'

Fixes plugin errors See merge request softwares-pkp/plugins_ojs/thoth-omp-plugin!26
thoth-pub · Sep 27, 2024 · 64f3128 · 64f3128
2 parents 9c786f2 + e8d1c47
commit 64f3128
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/ThothPlugin.inc.php b/ThothPlugin.inc.php
@@ -20,6 +20,7 @@
 import('plugins.generic.thoth.classes.ThothNotification');
 import('plugins.generic.thoth.classes.ThothRegister');
 import('plugins.generic.thoth.classes.ThothUpdater');
+import('plugins.generic.thoth.lib.thothAPI.exceptions.ThothException');
 
 class ThothPlugin extends GenericPlugin
 {
@@ -128,7 +129,7 @@ public function getThothClient($contextId = null)
         $password = $this->getSetting($contextId, 'password');
 
         if (!$email || !$password) {
-            throw new ThothException("Credentials not configured");
+            throw new ThothException("Credentials not configured", 0);
         }
 
         import('plugins.generic.thoth.lib.APIKeyEncryption.APIKeyEncryption');

diff --git a/classes/services/ThothContributionService.inc.php b/classes/services/ThothContributionService.inc.php
@@ -57,6 +57,10 @@ public function register($thothClient, $author, $thothWorkId)
         $contribution = $this->newByAuthor($author);
         $contribution->setWorkId($thothWorkId);
 
+        if (!$contribution->getContributionType()) {
+            return;
+        }
+
         $contributors = ThothService::contributor()->getMany($thothClient, [
             'limit' => 1,
             'filter' => (!empty($author->getOrcid())) ?

diff --git a/version.xml b/version.xml
@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.1.0.0</release>
-	<date>2024-09-17</date>
+	<release>0.1.1.0</release>
+	<date>2024-09-27</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>