Merge pull request #18 from lepidus/stable-3_3_0

Feature/added contribution biography updating (OMP 3.3.0)

classes/components/forms/RegisterForm.inc.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * @file plugins/generic/thoth/classes/components/form/RegisterForm.inc.php
  *

classes/services/ThothContributionService.inc.php

@@ -22,6 +22,9 @@ class ThothContributionService
     public function new($params)
     {
         $contribution = new ThothContribution();
+        $contribution->setId($params['contributionId'] ?? null);
+        $contribution->setWorkId($params['workId'] ?? null);
+        $contribution->setContributorId($params['contributorId'] ?? null);
         $contribution->setContributionType($params['contributionType']);
         $contribution->setMainContribution($params['mainContribution']);
         $contribution->setContributionOrdinal($params['contributionOrdinal']);
@@ -48,7 +51,7 @@ public function getDataByAuthor($author)
         $data['firstName'] = $author->getLocalizedGivenName();
         $data['lastName'] = $author->getLocalizedData('familyName');
         $data['fullName'] = $author->getFullName(false);
-        $data['biography'] = $author->getLocalizedBiography();
+        $data['biography'] = strip_tags($author->getLocalizedBiography());
         return $data;
     }
 
@@ -99,8 +102,13 @@ public function updateContributions($thothClient, $thothContributions, $publicat
 
         foreach ($authors as $author) {
             $publicationContribution = $this->getDataByAuthor($author);
-            if (!$this->contributionInList($publicationContribution, $thothContributions)) {
+            if (!$thothContribution = $this->contributionInList($publicationContribution, $thothContributions)) {
                 $this->register($thothClient, $author, $thothWorkId);
+                continue;
+            }
+            if ($thothContribution['biography'] !== $publicationContribution['biography']) {
+                $thothContribution['biography'] = $publicationContribution['biography'];
+                $thothClient->updateContribution($this->new($thothContribution));
             }
         }
     }
@@ -112,10 +120,10 @@ private function contributionInList($targetContribution, $contributions)
                 $contribution['firstName'] === $targetContribution['firstName']
                 && $contribution['lastName'] === $targetContribution['lastName']
             ) {
-                return true;
+                return $contribution;
             }
         }
-        return false;
+        return null;
     }
 
     private function isMainContribution($author)

lib/thothAPI/ThothClient.inc.php

@@ -129,6 +129,11 @@ public function updatePublication($publication)
         return $this->mutation('updatePublication', $publication);
     }
 
+    public function updateContribution($contribution)
+    {
+        return $this->mutation('updateContribution', $contribution);
+    }
+
     public function deleteWork($workId)
     {
         $data = ['workId' => $workId];

version.xml

@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.1.3.2</release>
-	<date>2024-10-25</date>
+	<release>0.1.3.3</release>
+	<date>2024-11-25</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>