Refactor the operators_test and report test coverage #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operators_test was a badly designed test suite, since it said it was just testing the operators but in fact it was also testing the process of parsing them, since it's much easier to specify operations using the GenericWebhookConfig CRD. The problem was that the CRD will evolve and the generic-k8s-webhook should support (and test) both old and new versions of the CRD. The refactor of the tests makes easier to keep test coverage for all the versions that are supported. Apart from that, we're introducing pytest-cov to write a test coverage report after executing all the unittests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operators_test was a badly designed test suite, since it said it was just testing the operators but in fact it was also testing the process of parsing them, since it's much easier to specify operations using the GenericWebhookConfig CRD.
The problem was that the CRD will evolve and the generic-k8s-webhook should support (and test) both old and new versions of the CRD. The refactor of the tests makes easier to keep test coverage for all the versions that are supported.
Apart from that, we're introducing pytest-cov to write a test coverage report after executing all the unittests.