-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop saying Administrate doesn't have a DSL #2505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
added
the
documentation
how to use administrate, examples and common usage
label
Feb 8, 2024
We also want to update |
nickcharlton
force-pushed
the
nc-rephrase-dsl
branch
from
January 10, 2025 15:32
3d9ae13
to
590fe2f
Compare
jutonz
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I like this a lot :)
slickepinne
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
nickcharlton
force-pushed
the
nc-rephrase-dsl
branch
from
January 14, 2025 11:46
047e233
to
e5d0384
Compare
The original intent of the line in the README was to emphasise that it's not fully DSL-driven, instead as close to standard Rails as possible. This rephrases to avoid saying "we don't have a DSL", but try and provide a more useful way to describe the projects' vision. Closes #2267
nickcharlton
force-pushed
the
nc-rephrase-dsl
branch
from
January 14, 2025 11:58
e5d0384
to
3c439d4
Compare
nickcharlton
added a commit
that referenced
this pull request
Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but that pointed to some other things which are outdated in the README and Gemspec. This goes further with the rephrasing to remove some weasle words, comparisons to other frameworks (which made more sense when it was first released) and try to improve the vision we're pitching for Administrate now and into the future.
nickcharlton
added a commit
that referenced
this pull request
Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but that pointed to some other things which are outdated in the README and Gemspec. This goes further with the rephrasing to remove some weasle words, comparisons to other frameworks (which made more sense when it was first released) and try to improve the vision we're pitching for Administrate now and into the future.
nickcharlton
added a commit
that referenced
this pull request
Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but that pointed to some other things which are outdated in the README and Gemspec. This goes further with the rephrasing to remove some weasle words, comparisons to other frameworks (which made more sense when it was first released) and try to improve the vision we're pitching for Administrate now and into the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of the line in the README was to emphasise that it's not fully DSL-driven, instead as close to standard Rails as possible.
This rephrases to avoid saying "we don't have a DSL", but try and provide a more useful way to describe the projects' vision.
Closes #2267