Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop saying Administrate doesn't have a DSL #2505

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

nickcharlton
Copy link
Member

The original intent of the line in the README was to emphasise that it's not fully DSL-driven, instead as close to standard Rails as possible.

This rephrases to avoid saying "we don't have a DSL", but try and provide a more useful way to describe the projects' vision.

Closes #2267

@nickcharlton nickcharlton added the documentation how to use administrate, examples and common usage label Feb 8, 2024
@nickcharlton nickcharlton added this to the v1.0.0 milestone Nov 19, 2024
@nickcharlton
Copy link
Member Author

We also want to update administrate.gemspec, as it has the same words in it.

Copy link

@jutonz jutonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I like this a lot :)

Copy link
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

README.md Outdated Show resolved Hide resolved
The original intent of the line in the README was to emphasise that it's
not fully DSL-driven, instead as close to standard Rails as possible.

This rephrases to avoid saying "we don't have a DSL", but try and
provide a more useful way to describe the projects' vision.

Closes #2267
@nickcharlton nickcharlton merged commit 20503b6 into main Jan 14, 2025
27 checks passed
@nickcharlton nickcharlton deleted the nc-rephrase-dsl branch January 14, 2025 12:03
nickcharlton added a commit that referenced this pull request Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but
that pointed to some other things which are outdated in the README and
Gemspec.

This goes further with the rephrasing to remove some weasle words,
comparisons to other frameworks (which made more sense when it was first
released) and try to improve the vision we're pitching for Administrate
now and into the future.
nickcharlton added a commit that referenced this pull request Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but
that pointed to some other things which are outdated in the README and
Gemspec.

This goes further with the rephrasing to remove some weasle words,
comparisons to other frameworks (which made more sense when it was first
released) and try to improve the vision we're pitching for Administrate
now and into the future.
nickcharlton added a commit that referenced this pull request Jan 14, 2025
In #2505, we stopped saying that Administrate doesn't have a DSL, but
that pointed to some other things which are outdated in the README and
Gemspec.

This goes further with the rephrasing to remove some weasle words,
comparisons to other frameworks (which made more sense when it was first
released) and try to improve the vision we're pitching for Administrate
now and into the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation how to use administrate, examples and common usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading claim on readme: administrate does have a DSL.
3 participants