Add Standardrb #1021
Open
Add Standardrb #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardrb flagged this class method being defined under private isn't actually private. We in fact doesn't want it to be private because it's being called by create_migration.
Rubocop/Standard wants to use `&` instead of `&block` and that newer syntax rule breaks Ruby 3.0.4 tests
Standard accidentally took away **options in Authorization. This change replaces it and updates the Gemfile.lock while I'm here.
sej3506
force-pushed
the
ms-standard
branch
from
5247415
to
5fcdf59
Compare
sej3506
force-pushed
the
ms-standard
branch
from
5fcdf59
to
ba8a6e6
Compare
|
I'd love to see this gem use standard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
standardfor linting and fixes the offenses.