engine/gRPC proxy: Fix mux regression and add test coverage #1456
Conversation
|
Yeppers! Pooshed f9ac86d |
|
Please continue to add HTTP CORS support, in order to better use it in the web （吴兴） |
| if !ok || username != s.Config.RemoteControl.Username || password != s.Config.RemoteControl.Password { | ||
| w.Header().Set("WWW-Authenticate", `Basic realm="restricted"`) | ||
| http.Error(w, "Access denied", http.StatusUnauthorized) | ||
| return |
There was a problem hiding this comment.
Suggestion: It might be better to log an authentication failure server side as well.
There was a problem hiding this comment.
Added with a note: by default we bind to localhost so you'd be notified if something on your machine is trying to gain access to it (with ip reported being localhost). However, it would be good if someone changes the listen address and in that case the IP log would be more useful
@brook-w Good suggestion but out of scope for this as this will probably need a middleware handler and integration with config, PR's are welcome. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
+ Coverage 43.39% 43.83% +0.44%
==========================================
Files 367 363 -4
Lines 147096 145034 -2062
==========================================
- Hits 63829 63582 -247
+ Misses 75444 73723 -1721
+ Partials 7823 7729 -94
|
PR Description
A user spotted a regression in Slack that the mux wasn't set for the gRPC proxy handler. This PR adds it back and adds test coverage.
Type of change
How has this been tested
Checklist