Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EventDispatcher): expose protected listeners #1375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HoloTheDrunk
Copy link

Resolves #1374

Exposes the _listeners storage as a protected field so extending classes can access it.
The testsuite only worked once then never again, skipping with a fetch error on attw that I couldn't find anywhere online. I'm assuming this is due to the proxy at my work, but either way I can't test this myself at the moment. Seems to work though and it shouldn't be a breaking change.

@HoloTheDrunk
Copy link
Author

HoloTheDrunk commented Nov 19, 2024

Oof, seems like this is a much more significant change than I'd expected since nothing around listeners was strictly typed...
Might even be a breaking change considering that there was absolutely no type checking on event types or anything before.
I'll try to work through the errors one by one but help would be appreciated. This large node of missing typing being ignored for so long has led to a rather inconveniently large number of dependent code doing JS in TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose EventDispatcher's _listeners as protected
1 participant