Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry mechanism on data loading when rebuild the data. #151

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

iwanbk
Copy link
Member

@iwanbk iwanbk commented Dec 19, 2024

We only retry on temporary errors like timeout.
retry also only enabled on data rebuild, not retrieve, because latency is not crucial during data rebuild.

Part of #5 improvements

@iwanbk iwanbk requested a review from LeeSmet as a code owner December 19, 2024 03:57
We only retry on temporary errors like timeout.
retry also only enabled on data rebuild, not retrieve,
because latency is not crucial during data rebuild.
Copy link
Contributor

@LeeSmet LeeSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact value of what a good timeout is, and if a retry implementation is sufficient, is likely going to require empyrical testing. For now I'll merge it so we can start doing that

@LeeSmet LeeSmet merged commit 1ba9a17 into master Dec 23, 2024
4 checks passed
@LeeSmet LeeSmet deleted the retry-load-data branch December 23, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants