Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a global setup manager instance #106

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Add a global setup manager instance #106

wants to merge 3 commits into from

Conversation

zaelgohary
Copy link
Collaborator

@zaelgohary zaelgohary commented Oct 29, 2024 •
edited
Loading

Changes

  • Added a setup manager in a global file and called it before all tests
  • Fixed tests typos

Tested Scenarios

  • Ran all tests

Related Issues

Checklist

  • Tests included
  • Build pass
  • Code format
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as ready for review October 30, 2024 12:21
@AhmedHanafy725 AhmedHanafy725 changed the base branch from main to development November 21, 2024 09:12
@AlaaElattar
Copy link
Contributor

AlaaElattar commented Dec 10, 2024 •
edited
Loading

  • From logs i can see that there's a new twinId created after each group.
  • There's 8 twins created, so each group gets different instance of setup manager.

@zaelgohary zaelgohary marked this pull request as draft December 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @AlaaElattar