Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reserve action button #3744

Closed
wants to merge 8 commits into from

Conversation

samaradel
Copy link
Contributor

Description

Fix the reserve action button.

Changes

  • Reduce check time of Un/Reserved buttons
  • Check the twin ID of the rented node when the component is mounted
  • Reset values after reserve / unreserve process

Related Issues

Tested Scenarios

  • Navigate to any solution
  • Switch on dedicated nodes
  • Reserve any node and unreserve it

Updated Scenarios

  • Reserve from the node page and un-reserve any from the solution page.
  • Reserve from a solution page, then un-reserve from the node page.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3650

@samaradel samaradel mentioned this pull request Dec 17, 2024
5 tasks
@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Feb 3, 2025

  • the reserve btn becomes active even after node has been reserved in node finder :/ when I press on it again I get the following console err but no toast explaining why. Btn should be disabled once reserve has been clicked.
    image
  • was able to reserve node from node finder and unreserve it from micro VM solution page
  • was able to reserve node from solution page and unresere it from node finder.

Please make sure reserve btn remains disabled once clicked and contract has been created.
https://www.loom.com/share/3b22f31ef4664a38b4595fc9ef33ae69?sid=19cc3840-4da4-4059-9871-80e8a96556e1

@samaradel samaradel marked this pull request as draft February 16, 2025 14:46
@samaradel samaradel marked this pull request as ready for review February 17, 2025 09:08
@AhmedHanafy725 AhmedHanafy725 deleted the development_2.7_reserve_action branch February 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants