Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor identity page #923

Open
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Feb 16, 2025

Changes

  • Refactor identity
  • Remove spending & unnecessary nested widgets
  • Fix resend button
  • Add click effect to email & phone tiles
  • Show loading dialogue while verifying
  • Remove the sequential verification steps (email first, then mobile). Now, email verification is separate from mobile verification.
  • Combine verified & current phase widget in one
  • Remove unverified widget
  • Remove KYC-related code
  • Remove 'Verify now' dialogue

Related Issues

Tested Scenarios

  • Navigate to Identity multiple times and check user data
  • Logout then login w diff account and navigate to identity
  • Verify mobile
  • Verify mail
  • Try to verify old mobile again
  • Verify mail after moile is verified
  • Verify from icon
  • Verify from button
  • Edit mobile
  • Edit mail

@zaelgohary zaelgohary changed the title Refactor identity, remove spending & unnecessary nested widgets, fix resend btn Refactor identity page Feb 17, 2025
@zaelgohary zaelgohary marked this pull request as ready for review February 17, 2025 11:35
@zaelgohary zaelgohary marked this pull request as draft February 18, 2025 07:55
@zaelgohary zaelgohary marked this pull request as ready for review February 19, 2025 14:37
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Here i'm not changing the phone number.

@AlaaElattar
Copy link
Contributor

  • Here i'm not changing the phone number.

  • I closed the dialog then clicked on the button again, the counter starts without even having a phone number.

@zaelgohary
Copy link
Contributor Author

Here i'm not changing the phone number.

Handled.

@AlaaElattar
Copy link
Contributor

  • I can't edit my phone number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants