secure farmer lan #2520
Open
secure farmer lan #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omarabdul3ziz
requested review from
muhamadazmy,
ashraffouda,
rawdaGastan,
xmonader and
Eslam-Nawara
as code owners
- apply the nft rules if only the default gw is private - explicitly allow traffic to all ips except the default gw network - except the router from the lan block - create a buffer with rules instead of executing commands - use the nft.Apply function for executing the buffer
delandtj
reviewed
Jan 21, 2025
|
|
||
| var buf bytes.Buffer | ||
| buf.WriteString("table inet filter {\n") | ||
| buf.WriteString(" chain forward {\n") |
There was a problem hiding this comment.
you're missing the type here
type filter hook forward priority filter; policy accept;
There was a problem hiding this comment.
this is already handled in the initial nft setup
| buf.WriteString(" }\n") | ||
| buf.WriteString("}\n") | ||
|
|
||
| return Apply(&buf, namesapce) |
There was a problem hiding this comment.
also, where do you apply the new table ?
There was a problem hiding this comment.
in ndmz namespace
|
update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apply implemented nft rules for farmer lan security in zos4, PRs:
Related issues