Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linter #14

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix linter #14

merged 1 commit into from
Oct 20, 2024

Conversation

rawdaGastan
Copy link

muhamadazmy
muhamadazmy approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember approving this PR before :)

Green light to merge when CI is fixed

@rawdaGastan
Copy link
Author

Tests are already failing in master branch, other workflows succeeds. Will merge

@rawdaGastan rawdaGastan merged commit 78ce6f4 into main Oct 20, 2024
24 of 25 checks passed
@rawdaGastan rawdaGastan deleted the development_fix_linter branch October 20, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz Omarabdul3ziz is a code owner

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

@Eslam-Nawara Eslam-Nawara Awaiting requested review from Eslam-Nawara Eslam-Nawara is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawdaGastan @muhamadazmy