Remove "Staking" page #10
Conversation
Removed pages and Sidebar component entry
Removed DeauthorizeApplication modal Added temporary solution for StakingOverview widget
Removed staking related components, unused hooks and modals. Removed staking related store entries, provided temporary soliutions to prevent compilation errors.
| StakingProviderAppInfo, | ||
| AuthorizationParameters, | ||
| } from "../../threshold-ts/applications" | ||
| import { AddressZero, MAX_UINT64 } from "../../threshold-ts/utils" |
There was a problem hiding this comment.
Non-blocking:
I think that we should also remove everything related to staking from threshold-ts lib. In the perfect world it would be best to have threshold-ts as a separate lib (in separate repo) and use it in both project.
The threshold-ts lib in this project is outdated already due to some changes that were made in Taco PR in the token-dashboard, so we won't be able to keep those two the same. I would say that we should remove all unnecessary things from it in this PR, and just leave the things that are relatd to TBTC.
There was a problem hiding this comment.
Actually, I will address this in a separate PR
src/pages/Staking/StakeCard/StakeBalance/LegacyStakeBalances/BalanceTreeItem.tsx
Show resolved
Hide resolved
Removed unused dependencies
Removed unused dependencies and imports
Fixed comment typos
src/pages/Staking/HowItWorks/StakingOverview/AuthorizingApplicationsCard.tsx
Show resolved
Hide resolved
| import { useToken } from "../../hooks/useToken" | ||
| import { tBTCFillBlack } from "../../static/icons/tBTCFillBlack" | ||
| import { TokenBalanceProps } from "../TokenBalance" | ||
|
|
||
| export type TokenBalanceCardProps = { | ||
| token: Exclude<Token, Token.TBTC> | ||
| token: Extract<Token, Token.TBTCV2> |
There was a problem hiding this comment.
Non-blocking:
Ideally we would not want to use Extract here in case we add other tokens to the Token anum. I will address that in a separate PR where I remove useFetchTvl hook and get rid of other tokens. For now, let's keep it this way.
"Main" branch clean-up Ref: #1 Depends on: #7 #8 #10 #11 This pull request aggregates each partial clean-up PR (mentioned above). It's introduced to reduce complexity of merge conflicts and allow continuous work without blocking while waiting for partial PRs to be merged. Moreover it's a place for general cleanup commits that couldn't be addressed to any of the PRs.
Ref: #1
This pull request removes "Staking" page and related components.