First step to remove legacy #153

vzotova · 2023-09-19T20:11:56Z

Removes most of legacy support: staking Keep/Nu, top-up Keep/Nu, increasing authorization to more than T stake.
Also adds method to deauthorize+unstake legacy stakes in one tx using involuntary decrease call. This method is permissionless.
Description of how this all would work can be found here #141. Additional to that - forceUnstakeLegacy method.
Second step will be removing forceUnstakeLegacy and all other usage of legacy stakes in TokenStaking after unstaking all legacy tokens.
P.S. stakedNu used in NuCypher StakingEscrow, for compatibility and will be removed at step 2 (together with link to Nu vending machine)

github-actions · 2023-09-19T20:14:08Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6240448509 check.

github-actions · 2023-09-19T20:14:59Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6240454444 check.

github-actions · 2023-09-19T20:22:57Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6240532295 check.

github-actions · 2023-09-19T20:26:55Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6240566891 check.

github-actions · 2023-09-19T21:26:29Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6241090131 check.

github-actions · 2023-09-19T22:09:31Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6241411525 check.

github-actions · 2023-09-19T22:44:12Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6241675809 check.

github-actions · 2023-09-21T19:27:36Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6266194951 check.

github-actions · 2023-09-21T22:55:18Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6267918668 check.

github-actions · 2023-09-28T20:26:58Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6343895490 check.

derekpierre

Would we want to do legacy removal as a potential EPIC branch instead of stages going into main? Or are there merge conflicts concerns of such a wide-reaching changes being in a separate branch for too long?

contracts/staking/TokenStaking.sol

contracts/staking/IStaking.sol

vzotova · 2023-09-29T14:27:44Z

Would we want to do legacy removal as a potential EPIC branch instead of stages going into main? Or are there merge conflicts concerns of such a wide-reaching changes being in a separate branch for too long?

It's not really an EPIC, because next PR will be done only after upgrading code to this one and unstake all legacy.

github-actions · 2023-09-29T14:28:44Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6353000229 check.

cygnusv

First pass

cygnusv · 2023-10-24T09:32:30Z

contracts/staking/IStaking.sol

-    function stakeNu(
-        address stakingProvider,
-        address payable beneficiary,
-        address authorizer
-    ) external;


contracts/staking/IStaking.sol

cygnusv · 2023-10-24T10:22:49Z

contracts/staking/TokenStaking.sol

+    // slither-disable-next-line constable-states
+    uint96 private legacyStakeDiscrepancyPenalty;
+    // slither-disable-next-line constable-states
+    uint256 private legacyStakeDiscrepancyRewardMultiplier;


What about removing these variables? Taking into consideration, of course, that they currently occupy a slot in the proxy storage layout.

That is whole point to have them - to not break slot layout for upgrades

cygnusv · 2023-10-24T10:26:58Z

contracts/staking/TokenStaking.sol

-        address indexed stakingProvider,
-        address indexed oldOwner,
-        address indexed newOwner
-    );


This feels refreshing

cygnusv · 2023-10-24T10:27:10Z

contracts/staking/TokenStaking.sol

-        VendingMachine _nucypherVendingMachine,
-        KeepStake _keepStake
-    ) {
+    constructor(T _token, VendingMachine _nucypherVendingMachine) {


contracts/staking/TokenStaking.sol

docs/rfc-1-staking-contract.adoc

github-actions · 2023-10-24T20:12:52Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6632026461 check.

contracts/staking/TokenStaking.sol

docs/rfc-1-staking-contract.adoc

contracts/staking/TokenStaking.sol

github-actions · 2023-11-09T14:28:12Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6813151919 check.

…ng authorization is possible only using T amount, disabled slashing for legacy stakes, keep unstaking for legacy stakes

…ment scripts

Co-authored-by: Derek Pierre <[email protected]>

Co-authored-by: David Núñez <[email protected]> Co-authored-by: Łukasz Zimnoch <[email protected]>

github-actions · 2023-11-14T14:10:49Z

Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6864773014 check.

After #153, which drop support for legacy stakers, TokenStaking constructor requires less arguments

vzotova force-pushed the remove-legacy-step-1 branch from 5fe11d2 to ee173ff Compare September 19, 2023 20:12

vzotova force-pushed the remove-legacy-step-1 branch from ee173ff to 0abb1ea Compare September 19, 2023 20:20

vzotova force-pushed the remove-legacy-step-1 branch from 0abb1ea to b66fbee Compare September 19, 2023 20:24

vzotova force-pushed the remove-legacy-step-1 branch from 0a3597d to 2f8aa67 Compare September 19, 2023 22:07

vzotova force-pushed the remove-legacy-step-1 branch from 2f8aa67 to 7b4c2ae Compare September 19, 2023 22:41

vzotova changed the title ~~[WIP] First step to remove legacy~~ First step to remove legacy Sep 22, 2023

vzotova marked this pull request as ready for review September 22, 2023 17:18

vzotova requested review from cygnusv and pdyraga as code owners September 22, 2023 17:18

vzotova requested review from arjunhassard, mswilkison, theref, nkuba, derekpierre, michalinacienciala and a team September 22, 2023 17:19

vzotova force-pushed the remove-legacy-step-1 branch from 0b123a6 to 92c1376 Compare September 28, 2023 20:24

derekpierre reviewed Sep 29, 2023

View reviewed changes

contracts/staking/TokenStaking.sol Outdated Show resolved Hide resolved

contracts/staking/IStaking.sol Outdated Show resolved Hide resolved

vzotova mentioned this pull request Sep 29, 2023

Adds autoIncrease flag to increase authorizations in topUp #155

Merged

nkuba requested a review from lukasz-zimnoch October 4, 2023 09:28

cygnusv reviewed Oct 24, 2023

View reviewed changes

cygnusv mentioned this pull request Nov 8, 2023

Drop support for legacy KEEP stakes #141

Closed

lukasz-zimnoch reviewed Nov 9, 2023

View reviewed changes

contracts/staking/TokenStaking.sol Show resolved Hide resolved

contracts/staking/TokenStaking.sol Show resolved Hide resolved

docs/rfc-1-staking-contract.adoc Outdated Show resolved Hide resolved

contracts/staking/TokenStaking.sol Show resolved Hide resolved

vzotova force-pushed the remove-legacy-step-1 branch from 094b765 to 676cb41 Compare November 9, 2023 14:26

cygnusv approved these changes Nov 14, 2023

View reviewed changes

vzotova and others added 6 commits November 14, 2023 09:07

Removes support for legacy staking in TokenStaking contract, increasi…

2f3e022

…ng authorization is possible only using T amount, disabled slashing for legacy stakes, keep unstaking for legacy stakes

Fixes solhint warning, removes system test job, removes legacy deploy…

a96041f

…ment scripts

Remove info about legacy stakes from docs

3dca8f7

Permissionless method to force unstake legacy stakes TokenStaking

ff371be

Apply suggestions from code review

837744c

Co-authored-by: Derek Pierre <[email protected]>

Apply suggestions from code review

1bc2a56

Co-authored-by: David Núñez <[email protected]> Co-authored-by: Łukasz Zimnoch <[email protected]>

vzotova force-pushed the remove-legacy-step-1 branch from 676cb41 to 1bc2a56 Compare November 14, 2023 14:08

lukasz-zimnoch approved these changes Nov 20, 2023

View reviewed changes

cygnusv merged commit 4b569b2 into main Nov 20, 2023
11 checks passed

cygnusv deleted the remove-legacy-step-1 branch November 20, 2023 10:16

cygnusv added a commit that referenced this pull request Nov 24, 2023

Update TokenStaking upgrade verification script

1861cf7

After #153, which drop support for legacy stakers, TokenStaking constructor requires less arguments

vzotova mentioned this pull request Mar 23, 2024

Risk of being frontrun when calling "notifyKeepStakeDiscrepancy" and "notifyNuStakeDiscrepancy" #83

Closed

cygnusv added a commit that referenced this pull request Sep 9, 2024

Update TokenStaking upgrade verification script

1f6493b

After #153, which drop support for legacy stakers, TokenStaking constructor requires less arguments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First step to remove legacy #153

First step to remove legacy #153

vzotova commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 28, 2023

derekpierre left a comment

vzotova commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

cygnusv left a comment

cygnusv Oct 24, 2023

cygnusv Oct 24, 2023

vzotova Oct 24, 2023

cygnusv Oct 24, 2023

cygnusv Oct 24, 2023

github-actions bot commented Oct 24, 2023

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 14, 2023

First step to remove legacy #153

First step to remove legacy #153

Conversation

vzotova commented Sep 19, 2023 • edited Loading

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 28, 2023

derekpierre left a comment

Choose a reason for hiding this comment

vzotova commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

cygnusv left a comment

Choose a reason for hiding this comment

cygnusv Oct 24, 2023

Choose a reason for hiding this comment

cygnusv Oct 24, 2023

Choose a reason for hiding this comment

vzotova Oct 24, 2023

Choose a reason for hiding this comment

cygnusv Oct 24, 2023

Choose a reason for hiding this comment

cygnusv Oct 24, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2023

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 14, 2023

vzotova commented Sep 19, 2023 •

edited

Loading