Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .env to .gitignore and add example env #602

Closed
wants to merge 1 commit into from

Conversation

theref
Copy link
Member

@theref theref commented Sep 1, 2023

.env should not be versioned controlled. Instead have an example env file

beaurancourt
beaurancourt previously approved these changes Sep 6, 2023
Copy link

@therealsphinx therealsphinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@@ -106,7 +106,7 @@ jobs:

- name: Run token-dashboard post-install script
shell: bash
run: yarn run postinstall
run: yarn run postinstall ; cp .env.example .env

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the time I thought we may env up missing an env file on deployments

@theref
Copy link
Member Author

theref commented Dec 20, 2023

fixed by #625

@theref theref closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants