SDK 1.4.1 integration #652

kpyszkowski · 2023-10-25T12:55:34Z

Integrated SDK 1.4.1 with dApp
Updated project to support Node 18
Tested build process for goerli and development packages
Bumped Node version in CI/CD process configuration files

Note:

There is a brand new warning while yarn installing ✨
It ain't a blocker and I couldn't pass through it easily so I decided to leave it for now.

Updated from 1.3.0-dev.9 to 2.0.0-dev.0

Applied changes proposed in commit d20aee1

Defined mock bitcoin network transaction fee. Adjusted missing/missplaced function parameters.

- Defined Node engine version in package.json file (<=16) - Added .nvmrc file for improved developer experience (https://github.com/nvm-sh/nvm#deeper-shell-integration) - Updated `@chakra-ui/cli` package (0.0.0-pr-20211126153854 -> 2.4.1) - Narrowed react-icons library versions scope (^4.3.1 -> <=4.3.1) - Bumped tsconfig module value (ES5 -> ES6) - Resolved Webpack issue with legacy Node polyfills (crypto) - (webpack/webpack#14532)

Bumped NodeJS version (14 -> 18)

package.json

.nvmrc

package.json

src/components/Modal/TbtcMintingConfirmationModal/index.tsx

src/tbtc/mock-bitcoin-client.ts

src/threshold-ts/tbtc/index.ts

src/utils/tBTC.ts

Updated `<=` into `>=`

Limited resolution to 4.8.0's patches (~)

Instead of analysing environmental variable the value is currently available to use in corelated data structures. Addded comment elaborating on mock Bitcoin network transaction fee. Refactored tBTC utility functions to pass bitcoin network as a parameter.

.github/workflows/reusable-build-and-publish.yml

lukasz-zimnoch

Last comments! Otherwise, LGTM! Leaving the final approval for @michalsmiarowski. Let's cut a release once this PR is merged and test those changes on mainnet preview.

.github/workflows/reusable-build-and-publish.yml

src/utils/tBTC.ts

src/threshold-ts/tbtc/index.ts

Removed unused imports and variables

kpyszkowski · 2023-10-26T13:39:34Z

@lukasz-zimnoch Your approval has been canceled, I had to push minor fixes 🙌🏼

Repositioned config comment

Updated lint-staged package to the latest version since it was causing issues with the latest Node version

github-actions · 2023-10-26T14:03:23Z

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-1.4.1-integration/index.html.

github-actions · 2023-10-26T14:18:11Z

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-1.4.1-integration/index.html.

github-actions · 2023-10-26T15:40:31Z

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-1.4.1-integration/index.html.

michalsmiarowski

Left one non-blocking comment down below

craco.config.js

michalsmiarowski · 2023-10-27T09:41:43Z

@kpyszkowski

It looks like all (or almost all) libraries in yarn.lock got updates which IMO is not a good idea as it is easy to miss some bugs and not all libraries could follow semantic versioning, which means not all changes could be non-braking. For example, since we updated prettier, we now had to do the changes in 545a5c3, but it looks like we don't have to update prettier to run the app on Node 18 and integrate SDK 1.4.1. It probalby got updated because you removed yarn.lock file while installing libs. For such a big transition (from Node 14 to 18) I believe the less changes we made the better. If we want to update some of the libraries, we can always do that in a separate PR.

As of now I recommend to:

Revert the yarn.lock file to it's main version
Revert the changes made in 545a5c3
In package.json revert react-icons to ^4.3.1 and lint-staged to >=10. As of now those updates are not necessary to migrate the app to Node 18
Run yarn install
Check if the site builds and run properly (I already checked that but it would be good to double check)
Push the changes to the branch

This reverts commit 545a5c3.

react-icons: `~4.8.0` -> `^4.3.1` lint-staged: `^15.0.2` -> `>=10`

kpyszkowski · 2023-10-27T14:00:48Z

@michalsmiarowski
Thanks for analysis. I have:

reverted 545a5c3 commit, ref: 7ca2f5d
checked out yarn.lock file to origin/main branch, ref: b8cfd0f
reverted updated packages, ref: 8972db2
added comment about @babel/plugin-transform-class-properties babel plugin, ref: f5b5358

I tested build processes for goerli and development packages, all works well.

github-actions · 2023-10-27T14:11:00Z

Preview uploaded to https://preview.dashboard.test.threshold.network/sdk-1.4.1-integration/index.html.

michalsmiarowski

LGTM

kpyszkowski added 2 commits October 24, 2023 15:43

Update @keep-network/tbtc-v2.ts package

f8e7f62

Updated from 1.3.0-dev.9 to 2.0.0-dev.0

Resolve ECPair library issue

890b3e0

Applied changes proposed in commit d20aee1

kpyszkowski linked an issue Oct 25, 2023 that may be closed by this pull request

Switch dApp to SDK v1.4.1 #647

Closed

kpyszkowski requested review from pdyraga, nkuba and lukasz-zimnoch as code owners October 25, 2023 13:04

kpyszkowski force-pushed the sdk-1.4.1-integration branch from 1b8a6e6 to c87c7b0 Compare October 25, 2023 14:51

kpyszkowski added 3 commits October 25, 2023 16:53

Integrate SDK API changes into dApp codebase

17c560d

Defined mock bitcoin network transaction fee. Adjusted missing/missplaced function parameters.

Adjust CI/CD process configs

b7f806a

Bumped NodeJS version (14 -> 18)

kpyszkowski force-pushed the sdk-1.4.1-integration branch from c87c7b0 to b7f806a Compare October 25, 2023 14:53

lukasz-zimnoch reviewed Oct 25, 2023

View reviewed changes

lukasz-zimnoch requested a review from michalsmiarowski October 25, 2023 15:24

kpyszkowski added 3 commits October 26, 2023 12:13

Fix Node version range typo

76ea124

Updated `<=` into `>=`

Update react-icons library version resolution

8734e57

Limited resolution to 4.8.0's patches (~)

kpyszkowski force-pushed the sdk-1.4.1-integration branch from 2cb19bd to d77bab2 Compare October 26, 2023 12:20

kpyszkowski added 2 commits October 26, 2023 14:27

Update @keep-network/tbtc-v2.ts version for goerli

221d9f6

Merge branch 'main' into sdk-1.4.1-integration

b9f1835

kpyszkowski commented Oct 26, 2023

View reviewed changes

.github/workflows/reusable-build-and-publish.yml Show resolved Hide resolved

lukasz-zimnoch previously approved these changes Oct 26, 2023

View reviewed changes

.github/workflows/reusable-build-and-publish.yml Show resolved Hide resolved

src/utils/tBTC.ts Outdated Show resolved Hide resolved

src/threshold-ts/tbtc/index.ts Outdated Show resolved Hide resolved

Add TODO comment

6b811a6

kpyszkowski dismissed lukasz-zimnoch’s stale review via 6b811a6 October 26, 2023 12:39

Code cleanup

7baf050

Removed unused imports and variables

lukasz-zimnoch previously approved these changes Oct 26, 2023

View reviewed changes

Resolve Prettier issues

545a5c3

kpyszkowski dismissed lukasz-zimnoch’s stale review via 545a5c3 October 26, 2023 13:35

kpyszkowski added 2 commits October 26, 2023 15:48

Resolve CI/CD issues

c57629b

Repositioned config comment

Update lint-staged package

85bd34f

Updated lint-staged package to the latest version since it was causing issues with the latest Node version

Fix lint-staged config file

1b645e3

michalsmiarowski requested changes Oct 27, 2023

View reviewed changes

craco.config.js Show resolved Hide resolved

michalsmiarowski added this to the v1.12.0 milestone Oct 27, 2023

kpyszkowski added 4 commits October 27, 2023 15:18

Revert "Resolve Prettier issues"

7ca2f5d

This reverts commit 545a5c3.

Checkout yarn.lock to origin/main branch

b8cfd0f

Revert updated packages

8972db2

react-icons: `~4.8.0` -> `^4.3.1` lint-staged: `^15.0.2` -> `>=10`

Explain babel plugin usage

f5b5358

michalsmiarowski approved these changes Oct 30, 2023

View reviewed changes

michalsmiarowski mentioned this pull request Oct 30, 2023

Fix ecpair lib error with babel plugin #642

Closed

lukasz-zimnoch approved these changes Oct 30, 2023

View reviewed changes

lukasz-zimnoch merged commit 50f2a42 into main Oct 30, 2023
5 checks passed

lukasz-zimnoch deleted the sdk-1.4.1-integration branch October 30, 2023 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK 1.4.1 integration #652

SDK 1.4.1 integration #652

kpyszkowski commented Oct 25, 2023 •

edited

Loading

lukasz-zimnoch left a comment

kpyszkowski commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

michalsmiarowski left a comment

michalsmiarowski commented Oct 27, 2023 •

edited

Loading

kpyszkowski commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

michalsmiarowski left a comment

SDK 1.4.1 integration #652

SDK 1.4.1 integration #652

Conversation

kpyszkowski commented Oct 25, 2023 • edited Loading

lukasz-zimnoch left a comment

Choose a reason for hiding this comment

kpyszkowski commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

michalsmiarowski left a comment

Choose a reason for hiding this comment

michalsmiarowski commented Oct 27, 2023 • edited Loading

kpyszkowski commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

michalsmiarowski left a comment

Choose a reason for hiding this comment

kpyszkowski commented Oct 25, 2023 •

edited

Loading

michalsmiarowski commented Oct 27, 2023 •

edited

Loading