Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify deposit telemetry parameters #664

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

lukasz-zimnoch
Copy link
Member

Refs: #648

SDK was updated so deposit parameters are now Hex. To properly display them in the Sentry telemetry hub, they must be converted to a string first.

SDK was updated so deposit parameters are now
`Hex`. To properly display them in Sentry telemetry
hub, they must be converted to string first.
@lukasz-zimnoch lukasz-zimnoch self-assigned this Nov 21, 2023
@lukasz-zimnoch lukasz-zimnoch added the ☁️ infrastructure CI, Infrastructure, Workflows label Nov 21, 2023
@lukasz-zimnoch lukasz-zimnoch added this to the v1.13.0 milestone Nov 21, 2023
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment to look at before the merge

src/hooks/tbtc/useDepositTelemetry.ts Show resolved Hide resolved
@michalsmiarowski michalsmiarowski self-requested a review November 21, 2023 10:39
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalsmiarowski michalsmiarowski merged commit e6ed52e into main Nov 21, 2023
5 checks passed
@michalsmiarowski michalsmiarowski deleted the fix-telemetry-params branch November 21, 2023 10:46
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ infrastructure CI, Infrastructure, Workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants