Feature/staking form ux improvements fixes #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 42bd970 we've changed the default messages in a way that they are related to Token staking. This is bad because now such messages were displayed in tbtc section (for example). This commit changes the default error message back to where it was before this commit.
The property name change is not needed because we usually use default `active` property from `useWeb3React` hook anyway.
The previosu commit introduces `shouldDisableButton` property which might get a little confusing, because when it's set to true someone might expect that the button is disabled no matter what, when in reality it relies on `isDisabled` property also. Instead of this, I've added `isDisabled` property for `Connect Wallet` button in SubmitTxButton component and set it to false. This overrides the `isDisabled` property from `...buttonProp`, because in this case we don't want ot have this button disabled anyway. This means that we can use `isDisabled` to disable token amount form if the account is not connected but keep the `Connect Wallet` button active.
kpyszkowski
reviewed
Nov 21, 2023
| requiredMessage: "The stake amount is required.", | ||
| greaterThanValidationMessage: defaultGreaterThanMessage, | ||
| lessThanValidationMessage: defaultLessThanMessage, | ||
| requiredMessage: "Required.", |
There was a problem hiding this comment.
I don't like this line. Full sentence will be more informative and simply elegant.
Something like "The value is required.". What do you think?
There was a problem hiding this comment.
I agree, but from what I see we use such message in other places too. I think it would be best to change it across the whole app.
@SorinQ What do you think? Maybe you could look into the dApp and let me know fi some validation messages could be improved?
kpyszkowski
merged commit 39d49e8
into
feature/staking-form-ux-improvements
4 of 5 checks passed
michalsmiarowski
added a commit
that referenced
this pull request
Nov 21, 2023
…x-improvements Improve staking form user experience Ref: #634 Added validation if user wallet is empty, simplified and made validation error messages more descriptive, improved readability of validation function, disabled form if wallet is not connected. Some of the issues were also addressed in #666, which was merged into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the review comments in #643.
Main changes:
isWalletConnectedproperty (see Improve staking form user experience #643 (comment))