Skip to content

fees: add max skipped blocks constant to pallet #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

gabriele-0201
Copy link
Contributor

Limit the number of skipped blocks in the fee update mechanism to the expected maximum.
This is done to avoid the possibility of incorrectly updating the fee multiplier.
For example, if the chain halts and skips more than 10000 blocks,
the approximation given by the first n terms of e^x could diverge significantly from the actual value.
Therefore, we set a boundary on the number of skipped blocks to ensure the accuracy of the approximation

@gabriele-0201 gabriele-0201 marked this pull request as ready for review January 25, 2024 09:54
Copy link
Contributor

rphmeier commented Jan 26, 2024

Merge activity

  • Jan 26, 2:02 PM: @rphmeier started a stack merge that includes this pull request via Graphite.
  • Jan 26, 2:03 PM: Graphite couldn't merge this PR because it had conflicts with the trunk branch.

Base automatically changed from rh-refactor-block-interval-const to main January 26, 2024 19:02
Limit the number of skipped blocks in the fee update mechanism to the expected maximum.
This is done to avoid the possibility of incorrectly updating the fee multiplier.
For example, if the chain halts and skips more than 10000 blocks,
the approximation given by the first n terms of e^x could diverge significantly from the actual value.
Therefore, we set a boundary on the number of skipped blocks to ensure the accuracy of the approximation
@rphmeier rphmeier force-pushed the gab_add_max_skipped_blocks_to_pallet branch from e9aec02 to 534b43d Compare January 26, 2024 20:59
@rphmeier rphmeier merged commit e362095 into main Jan 26, 2024
@rphmeier rphmeier deleted the gab_add_max_skipped_blocks_to_pallet branch January 26, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants