feat: overflow cells, writing overflow values #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
force-pushed
the
rh-overflow-pages-chunking
branch
from
789be31 to
d2b7ad6
Compare
rphmeier
force-pushed
the
rh-write-overflow-cells
branch
from
ce92f01 to
45c77dc
Compare
rphmeier
force-pushed
the
rh-overflow-pages-chunking
branch
from
d2b7ad6 to
b149add
Compare
rphmeier
force-pushed
the
rh-write-overflow-cells
branch
from
45c77dc to
9f01711
Compare
pepyakin
changed the base branch from
rh-overflow-pages-chunking
to
graphite-base/324
pepyakin
force-pushed
the
rh-write-overflow-cells
branch
from
9f01711 to
f99549a
Compare
pepyakin
force-pushed
the
rh-write-overflow-cells
branch
from
f99549a to
3d02d9e
Compare
rphmeier
force-pushed
the
rh-write-overflow-cells
branch
from
3d02d9e to
4d42aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the encoding of overflow cells and writing them in leaves.
In a leaf node, we use a 16-bit integer to encode the offset of each cell start. We take the high bit of this integer to encode whether the cell is an overflow cell or not.
When ingesting a value, if it's too large, we chunk it. Additionally,
LeafUpdater::ingesthas gained a callback for handling deletion of overflow cells. This will be fleshed out in the next PRs, along with loading of overflow values.I am not focusing on optimization at all at the moment, as it's clear that the beatree update logic needs to be rewritten for parallelism in any case and any optimization at this stage would be wasted effort.