feat: flesh out overlay update/commit functions #687
+165
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
force-pushed
the
rh-split-rollback-delta-creation-commit
branch
from
b43ea0b to
584754a
Compare
rphmeier
force-pushed
the
rh-overlay-api-finished
branch
from
7ea7225 to
d455b28
Compare
rphmeier
force-pushed
the
rh-split-rollback-delta-creation-commit
branch
from
584754a to
bc07047
Compare
rphmeier
force-pushed
the
rh-overlay-api-finished
branch
from
d455b28 to
39b1ea8
Compare
This was referenced Jan 14, 2025
gabriele-0201
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
One option to remove the clones (I think you are referring to extract everything from the overlay to later commit it), could be to switch from HashMap to BTreeMap within overlay::Data and then once its time to commit just move out pages and values from Data and a static iterator should be available!
| // Pages must store their ID before being written out. Set it here. | ||
| updated_page.page.set_page_id(&updated_page.page_id); | ||
| for (page_id, (page, page_diff)) in updated_pages { | ||
| // TODO: make sure to set page ID slot in page somewhere else. |
There was a problem hiding this comment.
Is this vestigial? because UpdatedPages::into_frozen_iter seems to do this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love the amount of cloning we do, but we can optimize that later.