fix(seglog): pop_front in memory log when pruning
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `self.shared.max_rollback_log_len` is reached and rollback delta needs to be pruned from the front, `prune_to_new_start_live` will be the `RecordId` just after the oldest delta in memory, thus `pop_front` is required.
pepyakin
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Nice, thanks.
This suggests that we might need to consider to change the reminology from front/back to something like push_recent and pop_oldest. It's vecdeque who cannot afford this, and we, working in the specific domain, can.
Would you be open to file a test for this case, while your wet caches are warm?
|
Yes, I will address renaming and tests in a follow up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
self.shared.max_rollback_log_lenis reached and rollback deltaneeds to be pruned from the front,
prune_to_new_start_livewill be theRecordIdjust after the oldest delta in memory, thuspop_frontis required.Closes THR-118