feat: page cache upper level prepopulation #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 11, 2025
pepyakin
approved these changes
Feb 12, 2025
| page_cache: &PageCache, | ||
| store: &Store, | ||
| levels: usize, | ||
| ) -> anyhow::Result<()> { |
There was a problem hiding this comment.
no can do unless I panic if the I/O pool goes down.
There was a problem hiding this comment.
yeah, that was the idea!
We do that everywhere so might as well do it here for at least consistency sake.
pepyakin
changed the base branch from
rh-fixed-level-cache
to
graphite-base/801
pepyakin
force-pushed
the
rh-THR-82-prepopulate
branch
from
6269261 to
b2e78c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepopulates the 3 upper levels of the page cache (to be made configurable in a follow-up) with a simple recursive algorithm.
Default is false.