Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove iopoll from io_uring #806

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

gabriele-0201
Copy link
Contributor

No description provided.

Copy link
Contributor Author

gabriele-0201 commented Feb 13, 2025

@gabriele-0201 gabriele-0201 merged commit 0b06aff into master Feb 14, 2025
8 checks passed
@gabriele-0201 gabriele-0201 deleted the gm_io_uring_stop_using_iopoll branch February 14, 2025 08:16
@deuszx
Copy link

deuszx commented Feb 14, 2025

Hey hey - just for the sake of my own learning: why did you remove this? Were there any issues with how this (not) worked?

@gabriele-0201
Copy link
Contributor Author

As state in the docs:

This is only applicable for storage devices for now, and the storage device must be configured for polling
...
the nvme driver must be loaded with the poll_queues parameter set to the desired number of polling queues

What this means is that iopoll requires some really low-level configuration to work properly, it is not plug and play. If you try to cat /sys/module/nvme/parameters/poll_queues, you will probably get a zero, indicating that your nvme is not configured for polling. This is why it was removed for now, it was not providing any real benefit at some costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants