fix(torture): use the right rr #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 21, 2025
gabriele-0201
approved these changes
Feb 21, 2025
pepyakin
changed the base branch from
pep-fix-torture-spawn-sock-nonblocking
to
graphite-base/822
This PR fixes the issue when the workload might error out because of the Broken Pipe error. This is unmasked by the previous PR in the stack. The error is that the rr is not reloaded for sampling/checking the snapshot applied/not applied after a crash. Instead the rr of the dead process was used. This fix comes with a refactor where we store the rr in a field and keep it synchronized with the agent. This seems to be an easier task than trying to keep from not reloading it at the right time.
pepyakin
force-pushed
the
pep-fix-torture-reload-rr
branch
from
0266eca to
72ba3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when the workload might error out because of the
Broken Pipe error. This is unmasked by the previous PR in the stack.
The error is that the rr is not reloaded for sampling/checking the
snapshot applied/not applied after a crash. Instead the rr of the dead
process was used.
This fix comes with a refactor where we store the rr in a field and keep
it synchronized with the agent. This seems to be an easier task than
trying to keep from not reloading it at the right time.