Skip to content

Support installer declarations #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Lordfirespeed
Copy link
Contributor

Does what it says on the tin!

In addition

  • Update language version to C# 12
  • Remove all default values from the TOML schema definition
  • Update DefaultConfig with the aforementioned default values
  • Ensure tcli init's created thunderstore.toml uses only configuration from the default config

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Project coverage is 5.36%. Comparing base (10b73c8) to head (20e6bcc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ThunderstoreCLI/Models/ThunderstoreProject.cs 0.00% 40 Missing ⚠️
ThunderstoreCLI/Configuration/Config.cs 0.00% 36 Missing ⚠️
ThunderstoreCLI/Configuration/DefaultConfig.cs 0.00% 19 Missing ⚠️
ThunderstoreCLI/Configuration/ProjectFileConfig.cs 0.00% 15 Missing ⚠️
...hunderstoreCLI/Configuration/CLIParameterConfig.cs 0.00% 8 Missing ⚠️
ThunderstoreCLI/Commands/BuildCommand.cs 0.00% 7 Missing ⚠️
ThunderstoreCLI/PackageManifestV1.cs 0.00% 2 Missing ⚠️
ThunderstoreCLI/API/ApiHelper.cs 0.00% 1 Missing ⚠️
ThunderstoreCLI/Commands/InitCommand.cs 0.00% 1 Missing ⚠️
ThunderstoreCLI/Commands/PublishCommand.cs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #100      +/-   ##
=========================================
- Coverage    5.47%   5.36%   -0.11%     
=========================================
  Files          42      42              
  Lines        2413    2461      +48     
  Branches      237     239       +2     
=========================================
  Hits          132     132              
- Misses       2278    2326      +48     
  Partials        3       3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant