Implement Spot Test Network #409
Draft
+91
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagosiebler
requested changes
Mar 4, 2024
tiagosiebler
requested changes
Mar 11, 2024
| @@ -280,9 +281,11 @@ export interface SymbolLotSizeFilter { | |||
| } | |||
|
|
|||
| export interface SymbolMinNotionalFilter { | |||
| filterType: 'MIN_NOTIONAL'; | |||
| filterType: 'NOTIONAL'; | |||
There was a problem hiding this comment.
This is a breaking change, MIN_NOTIONAL is definitely there for futures:
https://binance-docs.github.io/apidocs/futures/en/#filters
and for spot as well:
https://binance-docs.github.io/apidocs/spot/en/#filters
Seems I don't have an interface yet for filterType: 'NOTIONAL', I'd welcome a change to add it, but it should not be at the cost of removing the existing SymbolMinNotionalFilter interface. You can make a new one such as SymbolNotionalFilter, but please revert this breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional Infos
Official resource from binance: https://testnet.binance.vision