-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edk2_initialize: add edk2_init
invocable
#560
Open
Javagedes
wants to merge
8
commits into
tianocore:feature/1.0.0
Choose a base branch
from
Javagedes:1.0.0-stuart_init
base: feature/1.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
force-pushed
the
1.0.0-stuart_init
branch
2 times, most recently
from
May 19, 2023 23:41
ec7fb6f
to
0a7e26d
Compare
Javagedes
force-pushed
the
1.0.0-stuart_init
branch
from
May 19, 2023 23:58
0a7e26d
to
ae7d55e
Compare
Javagedes
changed the title
edk2_initialize: add edk2_initialize
edk2_initialize: add May 19, 2023
edk2_init
invocable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/1.0.0 #560 +/- ##
=================================================
- Coverage 78.74% 78.39% -0.36%
=================================================
Files 47 46 -1
Lines 4785 4776 -9
=================================================
- Hits 3768 3744 -24
- Misses 1017 1032 +15
|
Javagedes
force-pushed
the
1.0.0-stuart_init
branch
3 times, most recently
from
July 17, 2023 21:41
28f84a1
to
36c4e42
Compare
Add the edk2_initialize invocable, which replaces edk2_setup and edk2_ci_setup. stuart_init is able to initialize both repositories and submodules. Merges edk2_setup and edk2_ci_setup tests. Updates documentation. Integration instructions: * import from edk2toolext.invocables.edk2_initialize rather than .edk2_setup or .edk2_ci_setup inside the configuration file * import Submodule and/or Repository instead of RequiredSubmodule * Where the parent class is specified, switch from SetupSettingsManager or CiSetupSettingsManager to InitializeSettingsManager * Use get_required_repositories and get_required_submodules instead of GetDependencies and GetRequiredSubmodules respectively * Use Submodule instead of RequiredSubmodule and Repository instead of a dictionary.
Javagedes
force-pushed
the
1.0.0-stuart_init
branch
from
July 17, 2023 21:56
36c4e42
to
d73d6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
edk2_init
invocable, which replaces edk2_setup and edk2_ci_setup. stuart_init is able to initialize both repositories and submodules.Integration instructions:
Closes #556