RedfishPkg: Populate serial number in SMBIOS type 42 record

[thejaputta]

No description provided.

[igorkulchytskyy]

Looks good for me

[thejaputta]

Hi, all failing CI checks are related to "SpellCheck failing for 99 words". Those failing words are not related to this change. Any suggestions on how to handle this issue?

[mdkinney]

The spelling checks are in log, but does not fail CI. The real error is above those messages in the log:

PROGRESS - Running Build RELEASE
ERROR - Compiler #2220 from D:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe.c(97): the following warning is treated as an error
WARNING - Compiler #4244 from D:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe.c(97): '=': conversion from 'UINTN' to 'UINT8', possible loss of data
ERROR - Compiler #1077 from NMAKE : fatal '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\bin\Hostx86\x86\cl.exe" /FoD:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\OUTPUT\.\ /showIncludes /nologo /arch:IA32 /c /WX /GS /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /ID:\a\1\s\RedfishPkg\RedfishHostInterfaceDxe  /ID:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\DEBUG  /ID:\a\1\s\MdePkg  /ID:\a\1\s\MdePkg\Include  /ID:\a\1\s\MdePkg\Test\UnitTest\Include  /ID:\a\1\s\MdePkg\Test\Mock\Include  /ID:\a\1\s\MdePkg\Library\MipiSysTLib\mipisyst\library\include  /ID:\a\1\s\MdePkg\Include\Ia32  /ID:\a\1\s\MdeModulePkg  /ID:\a\1\s\MdeModulePkg\Include  /ID:\a\1\s\MdeModulePkg\Test\Mock\Include  /ID:\a\1\s\RedfishPkg  /ID:\a\1\s\RedfishPkg\Include  /ID:\a\1\s\RedfishPkg\PrivateInclude\Crt  /ID:\a\1\s\RedfishPkg\Library\JsonLib  /ID:\a\1\s\RedfishPkg\Library\JsonLib\jansson\src @D:\a\1\s\Build\RedfishPkg\RELEASE_VS2022\IA32\RedfishPkg\RedfishHostInterfaceDxe\RedfishHostInterfaceDxe\OUTPUT\cc_resp_1.txt' : return code '0x2'
ERROR - Compiler #7000 from : Failed to execute command
ERROR - EDK2 #002 from : Failed to build module
CRITICAL - Build failed

[thejaputta]

It looks like the tianocore.PatchCheck passed all checks for each individual commit. However, the pipeline still failed. Any suggestions on how to get it fixed?

[ghbaccount]

@thejaputta , you are still trying to submit merge commit that can not pass PatchCheck.

I would suggest to squash all your commits into the single one, save its hash or save it as a text file via git format-patch
Then reset your changes, rebase branch and reapply saved commit via git am or git cherrypick ${savedhash} and force push your changes again.
Personally, I can not see new patches properly neither in this PR nor in your branch. Something strange happens and I'm getting "Unable to load page. Please reload page and try again" while navigating this PR.

I hope this help.

[thejaputta]

@thejaputta , you are still trying to submit merge commit that can not pass PatchCheck.

I would suggest to squash all your commits into the single one, save its hash or save it as a text file via git format-patch Then reset your changes, rebase branch and reapply saved commit via git am or git cherrypick ${savedhash} and force push your changes again. Personally, I can not see new patches properly neither in this PR nor in your branch. Something strange happens and I'm getting "Unable to load page. Please reload page and try again" while navigating this PR.

I hope this help.

@ghbaccount, thank you for the advice. Previously, I rebased the patches and force-pushed after running PatchCheck locally to ensure all CI checks passed. Today, I squashed all the commits and force-pushed the changes again. However, the PatchCheck test still fails.

[ghbaccount]

@thejaputta PatchCheck wants you to split the commit into components:

Checking git commit: d25c15d74f
RedfishPkg: Populate serial number in SMBIOS type 42 record
The commit message format passed all checks.
The code passed all checks.
The commit adds/modifies files in multiple packages:
 * EmulatorPkg/EmulatorPkg.dec
 * RedfishPkg/RedfishPkg.dec

I guess it expects that change in EmulatorPkg must be a single commit.
It seems to be some CI specific option, because the patch is passed check when running locally.

[thejaputta]

@thejaputta PatchCheck wants you to split the commit into components:

Checking git commit: d25c15d74f
RedfishPkg: Populate serial number in SMBIOS type 42 record
The commit message format passed all checks.
The code passed all checks.
The commit adds/modifies files in multiple packages:
 * EmulatorPkg/EmulatorPkg.dec
 * RedfishPkg/RedfishPkg.dec

I guess it expects that change in EmulatorPkg must be a single commit. It seems to be some CI specific option, because the patch is passed check when running locally.

Thank you. It might have been the issue. I have updated the merge request with 2 separate commits for each Pkg and this time PatchCheck passed.
tianocore.PatchCheckSuccessful in 44s — Build #20250402.1 succeeded