Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Footer) : Footer page #20

Merged
merged 23 commits into from
Apr 18, 2024
Merged

feat(Footer) : Footer page #20

merged 23 commits into from
Apr 18, 2024

Conversation

Vyshnav001
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 17, 2024

@Vyshnav001 is attempting to deploy a commit to the gdscsjec-devs Team on Vercel.

A member of the Team first needs to authorize it.

@anishshobithps
Copy link
Member

@Vyshnav001 is attempting to deploy a commit to the gdscsjec-devs Team on Vercel.

A member of the Team first needs to authorize it.

Not sure why is it asking me to authorize your PR everytime ?

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:22am

@anishshobithps
Copy link
Member

anishshobithps commented Apr 17, 2024

image

Make AR as red, and on Hover make Google DSC as Red only use the tiara_red, then add proper spacing between others.

To avoid confusion also rename one privacy policy as Refund Policy. Also there is Terms & Conditions.

@Vyshnav001
Copy link
Contributor Author

For some reason Footer is not properly displaying in Event page

@anishshobithps
Copy link
Member

For some reason Footer is not properly displaying in Event page

We will see to it, once #15 is merged!

@anishshobithps anishshobithps added the Blocked A another PR or issue is blocking it label Apr 17, 2024
@anishshobithps anishshobithps linked an issue Apr 17, 2024 that may be closed by this pull request
3 tasks
@Vyshnav001
Copy link
Contributor Author

@anishshobithps should i keep underline color also as red ?or white is fine ?

@anishshobithps
Copy link
Member

@anishshobithps should i keep underline color also as red ?or white is fine ?

Not sure if underline is going to look good ?

@rabilrbl
Copy link
Member

@Vyshnav001 is attempting to deploy a commit to the gdscsjec-devs Team on Vercel.
A member of the Team first needs to authorize it.

Not sure why is it asking me to authorize your PR everytime ?

He's using personal forked branch

Copy link
Member

@anishshobithps anishshobithps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the contact number should be changed, and the email is [email protected],

src/components/widgets/Footer.tsx Outdated Show resolved Hide resolved
@Vyshnav001
Copy link
Contributor Author

  1. phone number removed
  2. email id changed
  3. removed SJEC logo from the footer
  4. added link to privacy,refund,terms
  5. made folder to store all the SVG icons

@Vyshnav001 Vyshnav001 linked an issue Apr 17, 2024 that may be closed by this pull request
@anishshobithps anishshobithps removed the Blocked A another PR or issue is blocking it label Apr 18, 2024
@anishshobithps anishshobithps merged commit 4897949 into tiarasjec:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading page Important Pages and Section
4 participants