Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cursors: add glow to it #51

Merged
merged 1 commit into from
Apr 25, 2024
Merged

cursors: add glow to it #51

merged 1 commit into from
Apr 25, 2024

Conversation

anishshobithps
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Apr 25, 2024 6:28am

joywin2003
joywin2003 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@joywin2003 joywin2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont seem to be liking it much, its very catchy on the eyes and not in a good way, I dont feel its required

rabilrbl
rabilrbl approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@rabilrbl rabilrbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'm okay with this as long there is no performace implications, which I didn't find.

@anishshobithps anishshobithps merged commit 5eabceb into main Apr 25, 2024
3 checks passed
@anishshobithps anishshobithps deleted the cursors branch April 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joywin2003 joywin2003 joywin2003 left review comments

@rabilrbl rabilrbl rabilrbl approved these changes

@Vyshnav001 Vyshnav001 Awaiting requested review from Vyshnav001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anishshobithps @rabilrbl @joywin2003