Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more date range options for Shopify sales and orders apps #1782

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

jnormore
Copy link
Contributor

@jnormore jnormore commented Aug 29, 2023

Description

  • Add current day, week to date, month to date, year to date, etc date ranges to Shopify Sales and Shopify Orders apps.
  • Use new caching mechanism.
tidbyt:orders star 2023-08-28 23-30-03 tidbyt:sales star 2023-08-28 23-30-27

Copilot

🤖 Generated by Copilot at 215ec60

Summary

🚀🎨🐛

This pull request improves two Shopify apps, shopify_orders.star and shopify_sales.star, by using the new HTTP cache feature, adding more customization options, and fixing some bugs.

shopify_orders
HTTP cache, colors, dates
Autumn sales improve

Walkthrough

  • Simplify api_fetch function to use HTTP cache feature instead of manual caching (link, link)
  • Expand date range options and labels for orders and sales data (link, link, link, link)
  • Fix syntax errors by removing extra commas in render.Row and schema.Dynamic constructors (link, link, link, link)
  • Reorder imports alphabetically and remove unused imports to follow Python style guide (link, link)
  • Add api_config variable to store config field from API response (link, link)
  • Fix indentation of request_config and date_range_custom_options to use four spaces (link, link, link)
  • Change quotation marks for strings from double to single for consistency (link, link)

@tidbyt
Copy link

tidbyt bot commented Aug 29, 2023

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir Touches files in multiple directories
🟡 Modules Multiple .star files: apps/shopifyorders/shopify_orders.star, apps/shopifysales/shopify_sales.star
Original Author The original author matches the PR author

Previews

apps/shopifyorders/shopify_orders.star:

apps/shopifysales/shopify_sales.star:

@jnormore jnormore force-pushed the shopify_sales_new_date_ranges branch from 215ec60 to 357c166 Compare August 29, 2023 02:20
@matslina matslina merged commit 823fb80 into tidbyt:main Sep 5, 2023
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants