Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Soccer Single - Fix PK Score - wrong location - didn't test enough #1783

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

jvivona
Copy link
Contributor

@jvivona jvivona commented Aug 29, 2023

Description

Fixed Penalty Score display for Single Match - missed that it's somewhere else for single match results.

Copilot

🤖 Generated by Copilot at 2f518dc

Summary

🐛🆕🔢

Fixed a bug and added a feature to the soccersingle app for displaying soccer scores and standings on the Tidbyt device. Updated the app version in soccer_single.star.

The final whistle blows, the fate is sealed
No more goals, no more appeals
The penaltyScore is revealed, the crowd goes wild
The groupStandings are updated, the champions smile

Walkthrough

  • Fix bug in displaying penalty shootout score for single match results (link, link)

@tidbyt
Copy link

tidbyt bot commented Aug 29, 2023

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/soccersingle/soccer_single.star:

@jvivona
Copy link
Contributor Author

jvivona commented Aug 29, 2023

:shipit:

@matslina matslina merged commit 4a8f302 into tidbyt:main Sep 5, 2023
@jvivona jvivona deleted the soccer-pk-additional-20230829 branch September 5, 2023 18:13
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants