Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App: Aquarium #2855

Merged
merged 1 commit into from
Nov 5, 2024
Merged

New App: Aquarium #2855

merged 1 commit into from
Nov 5, 2024

Conversation

rjison
Copy link
Contributor

@rjison rjison commented Nov 4, 2024

An ever changing Aquarium scene with custom/random water color, and a different combination of coral and fish each time.

@rjison rjison requested a review from matslina as a code owner November 4, 2024 05:52
@tidbyt
Copy link

tidbyt bot commented Nov 4, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of random.star requires review
Original Author The original author matches the PR author

@matslina matslina merged commit 572ee60 into tidbyt:main Nov 5, 2024
2 checks passed
@rjison rjison deleted the Aquarium branch November 5, 2024 22:06
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants