Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing new app: shipweatherclock #2856

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

pcouth
Copy link
Contributor

@pcouth pcouth commented Nov 5, 2024

adding an app that displays:
1. Text of
- current time
- low and high temperatures for the day
- current temperature
2. Ship on the ocean scene with:
- wave animations based on windspeed
- sun and moon that rise/fall based on time to sunrise/sunset
- sky colors that change based on day/night/sunrise/sunset
- clouds and precipitation based on current weather

shipweatherclock

@pcouth pcouth requested a review from matslina as a code owner November 5, 2024 04:34
@tidbyt
Copy link

tidbyt bot commented Nov 5, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@tidbyt-bot
Copy link

tidbyt-bot commented Nov 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pcouth
Copy link
Contributor Author

pcouth commented Nov 5, 2024

I have read the CLA Document and I hereby sign the CLA

@matslina matslina merged commit 8db7dca into tidbyt:main Nov 5, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants