Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victron Module #2864

Closed
wants to merge 2 commits into from
Closed

Victron Module #2864

wants to merge 2 commits into from

Conversation

jduncc
Copy link
Contributor

@jduncc jduncc commented Nov 6, 2024

Hello,
This is a new app that integrates with the Victron VRM API to show energy data for a given Victron installation. API key is provided in the config to render actual data. Here is a sample:

victron

I have read the CLA Document and I hereby sign the CLA

Jonathan Desrochers added 2 commits November 5, 2024 19:31
@jduncc jduncc requested a review from matslina as a code owner November 6, 2024 01:58
@tidbyt
Copy link

tidbyt bot commented Nov 6, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@tidbyt-bot
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Jonathan Desrochers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@jduncc
Copy link
Contributor Author

jduncc commented Nov 6, 2024

I have read the CLA Document and I hereby sign the CLA

@jduncc jduncc closed this Nov 6, 2024
@jduncc jduncc deleted the victron branch November 6, 2024 21:48
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants