Update Thanksgiving Day app to dynamically calculate days till thanksgiving #2872
Conversation
Current logic only works for 2024 and 2025. New logic works indefinitely.
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![tidbyt[bot]](https://avatars.githubusercontent.com/u/57181397?s=60&v=4){kind=small}
|
I have read the CLA Document and I hereby sign the CLA |
Update > 0 day logic to >= 0
savdagod
changed the title
| print(thanksgiving) | ||
| days_til_thanksgiving = math.ceil(time.parse_duration(thanksgiving - now).seconds / 86400) | ||
| print(days_til_thanksgiving) | ||
| timezone = config.get("timezone") or "America/New_York" |
There was a problem hiding this comment.
Should this be timezone = config.get("$tz", "America/New_York")?
There was a problem hiding this comment.
I’m gonna be honest, I have no idea. Looks to be that way ($tx) in some of the other countdown apps (ie Christmas) but it’s this way (timezone) in the Halloween countdown. Not sure which way is the correct way.
There was a problem hiding this comment.
The Halloween countdown app was fixed in #2854.
There was a problem hiding this comment.
Ah i see, I'll go ahead and update it then
Current logic is hard coded for 2024 and 2025. This update changes the logic to calculate the days indefinitely.