Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news api is down, replacing with alternate news api #2873

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

vipulchhajer
Copy link
Contributor

news api is down, replacing with alternate news api which requires slightly different parameters. Added a time function in service of limiting news to between today and yesterday.

@tidbyt
Copy link

tidbyt bot commented Nov 10, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@vipulchhajer
Copy link
Contributor Author

Hi @matslina @rohansingh could either of you review this PR? The India News app is broken and this PR fixes it.

@rohansingh rohansingh merged commit d100fcf into tidbyt:main Nov 20, 2024
2 checks passed
@vipulchhajer
Copy link
Contributor Author

vipulchhajer commented Nov 20, 2024

Hi @matslina Could you review and merge the PR? Since I tagged you in a comment, Github requires your review and won't merge.

Ah never mind, I clearly don't understand how Github works lol.

@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants