Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MealViewer #2884

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Add MealViewer #2884

merged 5 commits into from
Nov 24, 2024

Conversation

jed
Copy link
Contributor

@jed jed commented Nov 19, 2024

This app uses the MealViewer API to display what's next being served for lunch at a participating school.

mealviewer

@jed jed requested a review from matslina as a code owner November 19, 2024 04:10
@tidbyt
Copy link

tidbyt bot commented Nov 19, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

@rohansingh
Copy link
Member

For caching of HTTP requests, please pass ttl_seconds to http.get instead of using the cache directly.

@rohansingh rohansingh merged commit 1016f59 into tidbyt:main Nov 24, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants