-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deprecations #6138
base: main
Are you sure you want to change the base?
Bump deprecations #6138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a revdepcheck for this before we fully commit. I agree in principle about the timespan
revdepchecks have been committed |
So about 30/347 packages show up with at least a deprecation warning. This comes with the caveat that we only see warnings when something else is wrong too: I don't think throwing a warning includes a package in the problems section. I think we might be slightly too aggressive about erroring on the theme settings, as giving a wrong argument usually gives a warning, not an error. Honestly I'm kind of baffled that some packages still use arguments that were deprecated since ggplot2 2.0.0 (i.e. 10 years ago). |
Per #6281 (comment):
Regarding |
Merge branch 'main' into bump_deprecations # Conflicts: # R/stat-bin.R
This PR does not fix an issue, but I see it as regular maintenance.
Briefly, it converts
deprecate_warn0()
tolifecycle::deprecate_stop()
for functions/arguments that were deprecated prior to ggplot 3.3.0.It converts
deprecate_soft0()
todeprecate_warn0()
for functions/arguments that were deprecated up to ggplot2 3.2.0 and removes examples.I thought 5 years to be an OK horizon for deprecation warnings and I felt it was time to stop allowing things from the previous major version. Happy to make these timelines shorter though :)