-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial infrastructure for editions #6203
base: main
Are you sure you want to change the base?
Conversation
Add a few example cases to edition |
To answer some of the questions:
I think we expect maintainers to:
I don't have a full answer yet. Currently they can use |
After discussion with Thomas, we want to use editioning only to deprecate mostly vestigial parts and swap defaults, not for opting in to newer features. Some examples of things we want to edition:
|
This PR aims to adress a topic discussed by Thomas and me off-github.
Briefly, we'd like to bring edition structure to ggplot2 to opt-in otherwise backward incompatible changes. It is modelled after testthat, with a few adaptations. This PR just aims to introduce infrastructure for working with editions in ggplot2.
The most important difference with testthat is in the relation that it has to other packages. The testthat package has 1:1 relationships: the tests of one single package does not affect tests in a second package. In contrast, it is not unreasonable to assume that for example {extensionPkg} defines ggplot2 extensions, which are then subsequently used by wrappers in {wrapperPkg}. In this example {extensionPkg} and {wrapperPkg} might opt-in different editions, which needs to be facilitated. For this reason, this PR gives each package their own local edition.
This PR is currently marked WIP as some details need to be ironed out. Specifically: