Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facet: new method setup_panel_params to interact panel_params #6397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Facet: new method setup_panel_params to interact panel_params #6397

wants to merge 3 commits into from
+12 −1

Conversation

Yunuuuu
Copy link
Contributor

@Yunuuuu Yunuuuu commented Apr 5, 2025

fix #6380

This commit just add new method setup_panel_params in Facet object, and let Facet can act with the panel_params setted by Coord object before drawing.

teunbrand
teunbrand reviewed Apr 8, 2025
View reviewed changes
teunbrand
teunbrand approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one suggestion, this looks good to me. Do you want to add a news bullet?

@Yunuuuu @teunbrand
add dots for future extending
9889045 
Co-authored-by: Teun van den Brand <[email protected]>
@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Apr 8, 2025

Thanks for the reiviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Let Facet act with the panel_params
2 participants
@Yunuuuu @teunbrand