Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove older versions of CycloneDDS and FastRTPS libraries #367

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Goldob
Copy link
Contributor

@Goldob Goldob commented Nov 13, 2024

ROS2ForUnity is shipped with multiple versions of dependency libraries. A particular version of the library is denoted by numbers in the file extension. For example:

  • libfastrtps.so.2.6.2 is FastRTPS library in version 2.6.2;
  • libfastrtps.so.2.6.3 is the same library in version 2.6.3.

However, in newer versions of Unity, when parsing asset names, the last part of the file extension is stripped. In particular, both examples above become libfastrtps.so.2.6, which leads to errors about conflicts:

image

In this PR, conflicting older version of libraries are removed.

@Goldob Goldob requested a review from mackierx111 November 13, 2024 15:09
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit 22c4fe9 into main Nov 18, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants