Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvmg and dltype #631

Closed
wants to merge 4 commits into from
Closed

Conversation

lexavtanke
Copy link
Contributor

There are tvm_cli generated json files with tvmg and dltype words in tvm_utility package which are about to be merge in autowarefoundation/autoware.universe#4923.
They produce several warnings during the spell-check. And it is not possible to ignore them locally by cspell: ignore because comments aren't allowed in json files.

@lexavtanke
Copy link
Contributor Author

@HansRobo Hi, sorry for bothering you again but can you please review it?

Thank you in advance.

@HansRobo
Copy link
Member

@lexavtanke
Thank you for your contribution!
But, I'm being a little cautious about adding these words.
They don't seem to be a well-known or commonly seen abbreviation in the industry.

Would you consider adding the words to local dict below?
https://github.com/autowarefoundation/autoware.universe/blob/main/.cspell-partial.json

This config file is not for surpessing warning in pull-request now, but we are planning to make cspell CI for all directories required on the pull-requests and the file will be base of its config file.
So, adding the words to the file means ignoring the words in cspell checks in the future.

@lexavtanke
Copy link
Contributor Author

Hi @HansRobo! I've added tvmgen and dltype to local dict in this PR but It produce same errors by it self for now.
When are you going to make the changes you mention above?

Maybe we can merge this PR as temporal solution? and then changes in CI process will be done we can revert it back?
Or maybe you can suggest some better solution?

@HansRobo
Copy link
Member

HansRobo commented Oct 26, 2023

@lexavtanke
Sorry if my explanation is difficult to understand.
Could you add words to local dictionary not in new PR but in existing your PR?
Then, the new dictionary words will be available in your PR and cspell errors will resolve!

@HansRobo
Copy link
Member

@lexavtanke
Thank you for your cooperation!
I confirmed the spell-check-partial workflow was succeeded by adding the words to local dictionary in your PR.

@HansRobo HansRobo closed this Oct 26, 2023
@lexavtanke
Copy link
Contributor Author

@HansRobo Thank you for your help!

@lexavtanke lexavtanke deleted the add_tvmg_and_dltype branch October 26, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants