Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(words): add combobox #660

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

tier4-autoware-public-bot[bot]
Copy link
Contributor

@tier4-autoware-public-bot tier4-autoware-public-bot bot commented Mar 9, 2024

this word is not necessary, normally we should use

  • combo_box
  • ComboBox
  • combo box
    etc..

But there are some cases where cobobox is used, so it is ok to be allowed to use.

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 0868bfb into main Mar 9, 2024
5 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the add-word-combobox branch March 9, 2024 06:32
@HansRobo
Copy link
Member

@kosuke55
I think in many cases "combobox" can be split into "combo" and "box".
Are there any situations where you need "combobox" instead of "combo_box" or "ComboBox"?

@kosuke55
Copy link
Contributor

@HansRobo
oh, thanks. No it's not necessary, I can use "combo_box" or "ComboBox".
I just added without thinking well 🙏

@kosuke55
Copy link
Contributor

I searched in google and found some combobox cases, so is it ok not to revert this time?

@HansRobo
Copy link
Member

I think there is no problem if you have a reason to add it.
However, you need to write it in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants