Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(words): add annotationless #830

Closed
wants to merge 2 commits into from

Conversation

tier4-autoware-public-bot[bot]
Copy link
Contributor

@tier4-autoware-public-bot tier4-autoware-public-bot bot commented Oct 11, 2024

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hayato-m126 hayato-m126 requested a review from rej55 October 11, 2024 08:20
@rej55
Copy link

rej55 commented Oct 16, 2024

@HansRobo @h-ohta @mitsudome-r
Could you review this PR?

Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because annotationless is generally a compound word, it is recommended that you use it with a clear separator such as annotation less or annotation-less.
If you want to add annotationless without using any separators, you need to explain in this PR that annotationless is commonly used in society (or the industry).

Note

The fact that the PR creator is already using the word is not a basis for approval.
Please note that this repository is a dictionary, not a word list to avoid errors.

@hayato-m126
Copy link
Contributor

@hayato-m126
Copy link
Contributor

2024-10-17_15-46

@hayato-m126
Copy link
Contributor

@hayato-m126
Copy link
Contributor

@HansRobo
Both annotation-less and annotationless seem to be used.

@hayato-m126
Copy link
Contributor

Thanks for the review.
I will add word to local dictionary in pilot-auto repository.

auto-merge was automatically disabled October 17, 2024 07:04

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants