chore(duplicate_node_checker): print duplication name (autowarefounda…

…tion#6488) (#1180) Signed-off-by: Mamoru Sobue <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]>
tier4 · Mar 8, 2024 · 2c3156f · 2c3156f
1 parent c5a5436
commit 2c3156f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/system/duplicated_node_checker/config/duplicated_node_checker.param.yaml b/system/duplicated_node_checker/config/duplicated_node_checker.param.yaml
@@ -1,4 +1,4 @@
 /**:
   ros__parameters:
     update_rate: 10.0
-    add_duplicated_node_names_to_msg: false # if true, duplicated node names are added to msg
+    add_duplicated_node_names_to_msg: true # if true, duplicated node names are added to msg
diff --git a/system/duplicated_node_checker/package.xml b/system/duplicated_node_checker/package.xml
@@ -6,6 +6,7 @@
   <description>A package to find out nodes with common names</description>
   <maintainer email="[email protected]">Shumpei Wakabayashi</maintainer>
   <maintainer email="[email protected]">yliuhb</maintainer>
+  <maintainer email="[email protected]">Mamoru Sobue</maintainer>
   <license>Apache 2.0</license>
 
   <buildtool_depend>ament_cmake</buildtool_depend>

diff --git a/system/duplicated_node_checker/src/duplicated_node_checker_core.cpp b/system/duplicated_node_checker/src/duplicated_node_checker_core.cpp
@@ -69,7 +69,7 @@ void DuplicatedNodeChecker::produceDiagnostics(diagnostic_updater::DiagnosticSta
     if (add_duplicated_node_names_to_msg_) {
       std::set<std::string> unique_identical_names(identical_names.begin(), identical_names.end());
       for (const auto & name : unique_identical_names) {
-        msg += " " + name;
+        msg += "[" + name + "], ";
       }
     }
     for (auto name : identical_names) {