fix(pose_instability_detector): empty check order

tier4 · Sep 27, 2024 · a007188 · a007188
1 parent 8d261d7
commit a007188
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/localization/pose_instability_detector/src/pose_instability_detector.cpp b/localization/pose_instability_detector/src/pose_instability_detector.cpp
@@ -88,9 +88,12 @@ void PoseInstabilityDetector::callback_odometry(Odometry::ConstSharedPtr odometr
   }
 
   // If twist_buffer_ is empty OR the latest twist is too old, skip the following.
+  if (twist_buffer_.empty()) {
+    return;
+  }
   double latest_twist_age =
     (current_pose_time - rclcpp::Time(twist_buffer_.back().header.stamp)).seconds();
-  if (twist_buffer_.empty() || latest_twist_age > window_length_ * 1.5) {
+  if (latest_twist_age > window_length_ * 1.5) {
     return;
   }