Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): add new package #1020

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

shmpwk
Copy link
Collaborator

@shmpwk shmpwk commented Nov 16, 2023

Description

Chrry-pick duplicated node checker

autoware_launch.xx1

Tests performed

Test both Lsim and Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Owen-Liuyuxuan and others added 2 commits November 16, 2023 22:30
…ode names in ros2 (autowarefoundation#5286)

* add implementation for duplicated node checking

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* update the default parameters of system_error_monitor to include results from duplication check

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* fix typo in readme

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* update license

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* change module to the system module

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* follow json schema: 1. update code to start without default 2. add schema/config/readme/launch accordingly

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* add duplicated node checker to launch

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* fix var name to config for uniform launch

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* Update system/duplicated_node_checker/README.md

* Update system/duplicated_node_checker/README.md

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
…warefoundation#5382)

* add duplicated node names to msg

Signed-off-by: kyoichi-sugahara <[email protected]>

* align with launcher repository

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch system labels Nov 16, 2023
@shmpwk shmpwk merged commit 6a60009 into beta/v0.10.5 Nov 16, 2023
12 of 13 checks passed
@shmpwk shmpwk deleted the feat/duplicate_check branch November 16, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants